Repository navigation
fix(a11y): omit aria-controls on inactive tabs to prevent broken tabpanel references - #721
Open
dezzy-music wants to merge 1 commit into
Open
dezzy-music wants to merge 1 commit into
dezzy-music wants to merge 1 commit into
Conversation
…anel ID references (MergeFi#710)
|
@dezzy-music is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #710.
In tabs consumers such as ContributorDashboardClient, only the currently active tabpanel is mounted in the DOM. Previously, every tab rendered an aria-controls attribute pointing to its tabpanel id regardless of whether that panel existed in the DOM, triggering axe ARIA reference violations and misleading assistive technology.
Changes
Verification